Thread

1. articulatepang · 1790530678 · focus · HN ↗

   I prefer a slightly more general rule: Make Illegal States Unrepresentable. The "Parse, don't validate" rule is a special case of MISU.

   What's the difference? MISU applies even when there's no parsing-like transformation happening. For example, if you have a variable that represents the current state of a network connection, and let's say it can be Disconnected, or Connected to some IP address (this is an oversimplification).

   Then one way to do it would be

     struct {
       connected: bool,
       peer_ip: int32
     }
   

   The trouble is that this allows us to represent an illegal/meaningless state: we're disconnected but there's still some junk old peer_ip hanging in there. Even worse, we might have written

     struct {
       connected: bool,
       peer_ip: Option<int32>
     }
   

   Now we could have connected = true but peer_ip = None.

   The solution is to use a sum type:

     type connection = 
        Disconnected
      | Connected of int32
   

   (sorry for using made-up syntax; I hope it's clear to anyone familiar with Rust.)

   "Make Illegal States Unrepresentable" applies throughout your program, at every interface between modules or functions in the program, including but not limited to parsing input.

   1. laszlokorte · 1790532749 · focus · HN ↗

      In rust this would simply be

         enum ConnectionStste {
              Connected(u32),
              Disconnected
          }

      1. slopinthebag · 1790534500 · focus · HN ↗

         or

            struct Connected { peer_ip: u32 }
            struct Disconnected;
            struct Connection<State> { state: State }

         1. sendfoods · 1790536427 · focus · HN ↗

            Wouldn’t peer: Option<int32> be enough to represent this?

            None = disconnected

            1. atoav · 1790571660 · focus · HN ↗

               This opens you to the possible mistake of accidentally passing something of value None that then is mistakenly interpreted as a valid disconnect.

               In some cases using None that way is totally fine, but it is a trade off and the cleaner way is to use a separate type

Unofficial Hacker News client; not affiliated with Y Combinator.