‹ BackHN Continuity

Thread

I don't want to read what you didn't write

1070 points · 460 comments · mooreds

  1. zmmmmm · · focus · HN ↗
    It's funny, i push back on pull requests because there is too much description now - a 20 line change has pages and pages of generated description, rationalisation for why it is safe, defense of each design decision, analysis of risks and side effects. People are indignant, you're rejecting my change because there is too much documentation? And my response is, I don't have time to read it and you put me in the position where I can't afford not to - because approving the PR implies I did and accepted it. The investment to read all that for the value of a code change that I'm one prompt away from doing myself if I cared is just not high enough. So it's rejected.
    1. ramshanker · · focus · HN ↗
      You might be surprised how many organisations/ teams now don’t even review pull requests. Claude does coding, Codex do code review, and if developer did 5 round of this before pull request, we could very well just let CI merge.
      1. brailsafe · · focus · HN ↗
        and this is such a liability imo. I recently got fired for what I think was apparently merging a change to Kubeconfig that both the CTO and DevOps person approved. I made as damn sure as I could that the proposed change was good, but I needed their eyes on it and they clearly weren't, possibly be cause every other repo had a review bot and no special automatic deployment automations. The DevOps person literally commented and said "It's good to merge", who to trust
        1. veltas · · focus · HN ↗
          They may have done you a favour if that's what they sack you for, good luck finding another job!
          1. brailsafe · · focus · HN ↗
            That's how I'm treating it! Thanks
Open on Hacker News to reply ↗

Unofficial Hacker News client; not affiliated with Y Combinator.